-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sabrina/ssl errors #2511
Sabrina/ssl errors #2511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SabrinaTardio the code looks and works great! 👏 Not approving because it's a draft, but otherwise it's all good.
I've left a few suggestions based on my testing and our chatting. My additional, design-related suggestion would be to make the font bigger in the error pages.
Great job! 🚀
ab0d4c9
to
67b0f8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @SabrinaTardio !
Task/Issue URL: https://app.asana.com/0/0/1206880509171835/f
Tech Design URL: https://app.asana.com/0/0/1206862686877685/f
CC:
Description: In case of SSL error will give the user the option of bypass the error and visit the site anyway. See Figma → and https://app.asana.com/0/72649045549333/1206755044584061
Steps to test this PR:
For initial test please check out
shane/ssl-updates
branch of CSS and move the CSS folder on xcodeInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation